Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heading: Hide border controls by default #67105

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Heading: Hide border controls by default #67105

merged 1 commit into from
Nov 20, 2024
+1 −7

Conversation

aaronrobertshaw
Copy link
Contributor

Related:

What?

Makes border support controls for the heading block optional, i.e. not displayed by default.

Why?

The general consensus through work on #43247 is that default display of border controls should match the display of margin and padding controls.

The heading block makes margin and padding optional controls so they have to be toggled on via the Dimension panel's ToolsPanel button. This PR makes the border controls consistent with that.

How?

Removes default controls config for border controls in the Heading block.json.

Testing Instructions

  1. Edit a post and add a heading block
  2. Ensure that the border controls are hidden by default
  3. Toggle on the border controls and make sure they work as expected.

Screenshots or screencast

Before After
Screenshot 2024-11-19 at 7 44 12 pm Screenshot 2024-11-19 at 7 43 37 pm

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Nov 19, 2024
@aaronrobertshaw aaronrobertshaw self-assigned this Nov 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 19, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: aaronrobertshaw <[email protected]>
Co-authored-by: akasunil <[email protected]>
Co-authored-by: ramonjd <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions GitHub Actions
Copy link

Flaky tests detected in f40c8c3.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11910359862
📝 Reported issues:

ramonjd
ramonjd approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Trunk This PR
Screenshot 2024-11-20 at 11 29 51 am Screenshot 2024-11-20 at 11 29 56 am

@aaronrobertshaw aaronrobertshaw merged commit 0587619 into trunk Nov 20, 2024
76 checks passed
@aaronrobertshaw aaronrobertshaw deleted the fix/default-display-of-heading-border-controls branch November 20, 2024 00:37
@github-actions github-actions bot added this to the Gutenberg 19.8 milestone Nov 20, 2024
@bph bph added the [Block] Heading Affects the Headings Block label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akasunil akasunil akasunil approved these changes

@ramonjd ramonjd ramonjd approved these changes

@talldan talldan Awaiting requested review from talldan

@tellthemachines tellthemachines Awaiting requested review from tellthemachines

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@aaronrobertshaw aaronrobertshaw

Labels
[Block] Heading Affects the Headings Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 19.8
Development

Successfully merging this pull request may close these issues.
4 participants
@aaronrobertshaw @ramonjd @akasunil @bph